Skip to content

[23355] Add VS143 toolset#5910

Merged
MiguelCompany merged 4 commits into
masterfrom
VS143_CI
Jul 2, 2025
Merged

[23355] Add VS143 toolset#5910
MiguelCompany merged 4 commits into
masterfrom
VS143_CI

Conversation

@EugenioCollado

@EugenioCollado EugenioCollado commented Jul 1, 2025 •
edited by cferreiragonz
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates the Windows GitHub Action Runner toolsets, including v143 (VS2022).

@Mergifyio backport 3.2.x (do NOT backport to 2.14 as this update has been included in #5909)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NA Any new/modified methods have been properly documented using Doxygen.
  • NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NA New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado
Use VS143 toolset
905a90c 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado added this to the v3.3.0 - Frozen ❄️ milestone Jul 1, 2025
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Jul 1, 2025
@EugenioCollado

EugenioCollado commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

After merge, it is required to update the CI requirements to remove the v141 and add v143 @rsanchez15

MiguelCompany
MiguelCompany requested changes Jul 1, 2025
View reviewed changes

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to update the PLATFORM_SUPPORT.md, and also the documentation

@EugenioCollado
Platform doc update
773b1a0 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado

EugenioCollado commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Related documentation has been updated here: eProsima/Fast-DDS-docs#1092

@EugenioCollado
EugenioCollado requested review from MiguelCompany and removed request for richiprosima July 1, 2025 10:41
@EugenioCollado
Upload artifact
e6e08de 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
MiguelCompany
MiguelCompany requested changes Jul 1, 2025
View reviewed changes
Comment thread .github/workflows/reusable-windows-ci.yml
matrix:
vs-toolset:
- 'v142'
- 'v143'

@MiguelCompany MiguelCompany Jul 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the toolset to the name of the test job in line 157

@EugenioCollado
Added toolset version to job name
22687f3 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@MiguelCompany
MiguelCompany self-requested a review July 1, 2025 15:20
MiguelCompany
MiguelCompany approved these changes Jul 1, 2025
View reviewed changes

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
MiguelCompany merged commit 9868b8b into master Jul 2, 2025
27 checks passed
@MiguelCompany
MiguelCompany deleted the VS143_CI branch July 2, 2025 05:50
@EugenioCollado

EugenioCollado commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport 3.2.x

@mergify

mergify Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport 3.2.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jul 2, 2025
@EugenioCollado @mergify
Add VS143 toolset to Windows CI (#5910)
633cee9 
* Use VS143 toolset

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Platform doc update

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Upload artifact

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Added toolset version to job name

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
(cherry picked from commit 9868b8b)
@mergify mergify Bot mentioned this pull request Jul 2, 2025
Merged
13 tasks
MiguelCompany pushed a commit that referenced this pull request Jul 18, 2025
@mergify @EugenioCollado
Add VS143 toolset to Windows CI (#5910) (#5916)
e75b7c2 
* Use VS143 toolset



* Platform doc update



* Upload artifact



* Added toolset version to job name



---------


(cherry picked from commit 9868b8b)

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: EugenioCollado <121509066+EugenioCollado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes
@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@EugenioCollado @MiguelCompany